Open
Conversation
This is because like `stripPrefix` and `stripSuffix`, these functions are CodeUnit/CodePoint-agnostic. The same was also done for tests.
|
Please, don't fix older commits in newer ones
A problem introduced by commit X should be fixed in commit X, otherwise reviewing the code becomes very hard, as well as reading the git history after this gets merged. See also this post from Linux HID subsystem and libinput maintainer Peter Hutterer. Despite the post age it's well relevant today, "old but gold". |
Contributor
Author
|
@Hi-Angel thanks for the advice, but i'm not interested in purescript anymore (i haven't used it in years), feel free to take this up if you'd like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Add
startsWithandendsWithfunctions toData.String.CodeUnits.Fixes #127.
I know that there's still a bit of disagreement over whether this should be done or not, but I just opened this PR because it didn't take a lot of time. If it's ultimately decided against, feel free to close this PR.
To do:
stripPrefixandstripSuffixstripPrefixandstripSuffixData.String.NonEmptyChecklist: